Make the followbot only dispatch follow requests once per 30 day period

This commit is contained in:
Mark Felder 2021-02-19 09:47:25 -06:00
parent 2689463c7e
commit 3949cfdc24

View File

@ -1,10 +1,14 @@
defmodule Pleroma.Web.ActivityPub.MRF.FollowBotPolicy do defmodule Pleroma.Web.ActivityPub.MRF.FollowBotPolicy do
@behaviour Pleroma.Web.ActivityPub.MRF @behaviour Pleroma.Web.ActivityPub.MRF
alias Pleroma.Activity.Queries
alias Pleroma.Config alias Pleroma.Config
alias Pleroma.Repo
alias Pleroma.User alias Pleroma.User
alias Pleroma.Web.CommonAPI alias Pleroma.Web.CommonAPI
require Logger require Logger
import Ecto.Query
@impl true @impl true
def filter(message) do def filter(message) do
with follower_nickname <- Config.get([:mrf_follow_bot, :follower_nickname]), with follower_nickname <- Config.get([:mrf_follow_bot, :follower_nickname]),
@ -36,12 +40,13 @@ defmodule Pleroma.Web.ActivityPub.MRF.FollowBotPolicy do
|> List.flatten() |> List.flatten()
|> User.get_all_by_ap_id() |> User.get_all_by_ap_id()
|> Enum.each(fn user -> |> Enum.each(fn user ->
Logger.info("Checking if #{user.nickname} can be followed") since_thirty_days_ago = NaiveDateTime.utc_now() |> NaiveDateTime.add(-(86_400 * 30))
with false <- User.following?(follower, user), with false <- User.following?(follower, user),
false <- user.locked, false <- User.locked?(user),
false <- (user.bio || "") |> String.downcase() |> String.contains?("nobot") do false <- (user.bio || "") |> String.downcase() |> String.contains?("nobot"),
Logger.info("Following #{user.nickname}") false <- outstanding_follow_request_since?(follower, user, since_thirty_days_ago) do
Logger.info("#{__MODULE__}: Follow request from #{follower.nickname} to #{user.nickname}")
CommonAPI.follow(follower, user) CommonAPI.follow(follower, user)
end end
end) end)
@ -50,6 +55,20 @@ defmodule Pleroma.Web.ActivityPub.MRF.FollowBotPolicy do
{:ok, message} {:ok, message}
end end
defp outstanding_follow_request_since?(
%User{ap_id: follower_id},
%User{ap_id: followee_id},
since_datetime
) do
followee_id
|> Queries.by_object_id()
|> Queries.by_type("Follow")
|> where([a], a.inserted_at > ^since_datetime)
|> where([a], fragment("? ->> 'state' = 'pending'", a.data))
|> where([a], a.actor == ^follower_id)
|> Repo.exists?()
end
@impl true @impl true
def describe do def describe do
{:ok, %{}} {:ok, %{}}