From 5c8afbe646c874eea32d7063aa499c97191f3a6e Mon Sep 17 00:00:00 2001
From: Mark Felder <feld@feld.me>
Date: Tue, 11 Jun 2024 18:54:22 -0400
Subject: [PATCH] Fix tests

---
 lib/pleroma/web/push/impl.ex        | 10 ++++------
 test/pleroma/web/push/impl_test.exs |  7 +++++--
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/pleroma/web/push/impl.ex b/lib/pleroma/web/push/impl.ex
index 2bcfa97f5..d71e134cb 100644
--- a/lib/pleroma/web/push/impl.ex
+++ b/lib/pleroma/web/push/impl.ex
@@ -21,9 +21,7 @@ defmodule Pleroma.Web.Push.Impl do
 
   @doc "Builds webpush notification payloads for the subscriptions enabled by the receiving user"
   @spec build(Notification.t()) ::
-          list(%{content: map(), subscription: Subscription.t()})
-          | :error
-          | {:error, :unknown_type}
+          list(%{content: map(), subscription: Subscription.t()}) | []
   def build(
         %{
           activity: %{data: %{"type" => activity_type}} = activity,
@@ -62,9 +60,9 @@ defmodule Pleroma.Web.Push.Impl do
     end)
   end
 
-  def build(_) do
-    Logger.warning("Unknown notification type")
-    {:error, :unknown_type}
+  def build(notif) do
+    Logger.warning("WebPush: unknown activity type: #{inspect(notif)}")
+    []
   end
 
   @doc "Deliver push notification to the provided webpush subscription"
diff --git a/test/pleroma/web/push/impl_test.exs b/test/pleroma/web/push/impl_test.exs
index 0eead956f..169c380c7 100644
--- a/test/pleroma/web/push/impl_test.exs
+++ b/test/pleroma/web/push/impl_test.exs
@@ -5,6 +5,7 @@
 defmodule Pleroma.Web.Push.ImplTest do
   use Pleroma.DataCase, async: true
 
+  import ExUnit.CaptureLog
   import Mox
   import Pleroma.Factory
 
@@ -62,8 +63,10 @@ defmodule Pleroma.Web.Push.ImplTest do
   end
 
   @tag capture_log: true
-  test "returns error if notif does not match " do
-    assert Impl.build(%{}) == {:error, :unknown_type}
+  test "returns error if notification activity type does not match" do
+    assert capture_log(fn ->
+             assert Impl.build(%{}) == []
+           end) =~ "WebPush: unknown activity type"
   end
 
   @tag capture_log: true