Anon/pleroma
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Pleroma.Web.AdminAPI.MediaProxyCacheController: dialyzer errors

Browse Source 
lib/pleroma/web/admin_api/controllers/media_proxy_cache_controller.ex:64:call
The function call will not succeed.

Phoenix.Controller.json(
  _conn :: %{
    :assigns => %{:user => _, _ => _},
    :body_params => %{:urls => _, _ => _},
    _ => _
  },
  %{}
)

breaks the contract
(Plug.Conn.t(), term()) :: Plug.Conn.t()
This commit is contained in:
Mark Felder 2024-01-27 15:41:14 -05:00
parent 861c8ebfe4
commit 8b02c85810
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/pleroma/web/admin_api/controllers/media_proxy_cache_controller.ex
View File

@ -59,12 +59,12 @@ defmodule Pleroma.Web.AdminAPI.MediaProxyCacheController do
Enum.slice(entries, offset, page_size) Enum.slice(entries, offset, page_size)
end end
def delete(%{assigns: %{user: _}, body_params: %{urls: urls}} = conn, _) do def delete(%{assigns: %{user: _}, body_params: %{"urls" => urls}} = conn, _) do
MediaProxy.remove_from_banned_urls(urls) MediaProxy.remove_from_banned_urls(urls)
json(conn, %{}) json(conn, %{})
end end
def purge(%{assigns: %{user: _}, body_params: %{urls: urls, ban: ban}} = conn, _) do def purge(%{assigns: %{user: _}, body_params: %{"urls" => urls, "ban" => ban}} = conn, _) do
MediaProxy.Invalidation.purge(urls) MediaProxy.Invalidation.purge(urls)
if ban do if ban do

10
lib/pleroma/web/api_spec/operations/admin/media_proxy_cache_operation.ex
View File

@ -78,9 +78,9 @@ defmodule Pleroma.Web.ApiSpec.Admin.MediaProxyCacheOperation do
"Parameters", "Parameters",
%Schema{ %Schema{
type: :object, type: :object,
required: [:urls], required: ["urls"],
properties: %{ properties: %{
urls: %Schema{type: :array, items: %Schema{type: :string, format: :uri}} "urls" => %Schema{type: :array, items: %Schema{type: :string, format: :uri}}
} }
}, },
required: true required: true
@ -104,10 +104,10 @@ defmodule Pleroma.Web.ApiSpec.Admin.MediaProxyCacheOperation do
"Parameters", "Parameters",
%Schema{ %Schema{
type: :object, type: :object,
required: [:urls], required: ["urls"],
properties: %{ properties: %{
urls: %Schema{type: :array, items: %Schema{type: :string, format: :uri}}, "urls" => %Schema{type: :array, items: %Schema{type: :string, format: :uri}},
ban: %Schema{type: :boolean, default: true} "ban" => %Schema{type: :boolean, default: true}
} }
}, },
required: true required: true