Connection pool: Fix a possible infinite recursion if the pool is exhausted

This commit is contained in:
rinpatch 2020-05-07 16:11:48 +03:00
parent 7738fbbaf5
commit e94ba05e52

View File

@ -14,16 +14,14 @@ defmodule Pleroma.Gun.ConnectionPool.WorkerSupervisor do
) )
end end
def start_worker(opts) do def start_worker(opts, retry \\ false) do
case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do
{:error, :max_children} -> {:error, :max_children} ->
case free_pool() do if retry or free_pool() == :error do
:ok -> :telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})
start_worker(opts) {:error, :pool_full}
else
:error -> start_worker(opts, true)
:telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})
{:error, :pool_full}
end end
res -> res ->