Anon/pleroma
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename variable to make the worker retry logic easier to read

Browse Source 
The boolean value matches the intent of the "last_attempt" variable name now
This commit is contained in:
Mark Felder 2024-02-23 11:12:10 -05:00
parent 72fc41d891
commit f4e48bc53e
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
changelog.d/gun_pool3.skip Normal file
View File

4
lib/pleroma/gun/connection_pool/worker_supervisor.ex
View File

@ -18,10 +18,10 @@ defmodule Pleroma.Gun.ConnectionPool.WorkerSupervisor do
) )
end end
def start_worker(opts, retry \\ false) do def start_worker(opts, last_attempt \\ false) do
case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do case DynamicSupervisor.start_child(__MODULE__, {Pleroma.Gun.ConnectionPool.Worker, opts}) do
{:error, :max_children} -> {:error, :max_children} ->
funs = [fn -> retry end, fn -> match?(:error, free_pool()) end] funs = [fn -> last_attempt end, fn -> match?(:error, free_pool()) end]
if Enum.any?(funs, fn fun -> fun.() end) do if Enum.any?(funs, fn fun -> fun.() end) do
:telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts}) :telemetry.execute([:pleroma, :connection_pool, :provision_failure], %{opts: opts})