From 0d2922afb3bcfcdcc439f158d147db1f08d995c7 Mon Sep 17 00:00:00 2001 From: Edijs Date: Sun, 17 Feb 2019 14:37:24 -0700 Subject: [PATCH] Remove event listener when component destroy --- src/components/timeline/timeline.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/timeline/timeline.js b/src/components/timeline/timeline.js index a8a3495a84..d7f7029eb7 100644 --- a/src/components/timeline/timeline.js +++ b/src/components/timeline/timeline.js @@ -67,16 +67,18 @@ const Timeline = { document.addEventListener('visibilitychange', this.handleVisibilityChange, false) this.unfocused = document.hidden } - window.addEventListener('keydown', e => { - if (e.key === '.') this.showNewStatuses() - }) + window.addEventListener('keydown', this.handleShortKey) }, destroyed () { window.removeEventListener('scroll', this.scrollLoad) + window.removeEventListener('keydown', this.handleShortKey) if (typeof document.hidden !== 'undefined') document.removeEventListener('visibilitychange', this.handleVisibilityChange, false) this.$store.commit('setLoading', { timeline: this.timelineName, value: false }) }, methods: { + handleShortKey (e) { + if (e.key === '.') this.showNewStatuses() + }, showNewStatuses () { if (this.timeline.flushMarker !== 0) { this.$store.commit('clearTimeline', { timeline: this.timelineName })