Improve readability in fetchAnnouncements()

2022-07-14 18:49:36 -04:00 · 2022-07-14 18:49:36 -04:00 · f3d97cf917
commit f3d97cf917
parent 23a9a46580
1 changed files with 4 additions and 2 deletions
--- a/src/modules/announcements.js
+++ b/src/modules/announcements.js
@ -54,12 +54,14 @@ const announcements = {
          a[c.id] = c
          return a
        }, {})
+        const getWithinVisible = announcement => visibleObject[announcement.id]

        all.forEach(announcement => {
-          if (!visibleObject[announcement.id]) {
+          const visibleAnnouncement = getWithinVisible(announcement)
+          if (!visibleAnnouncement) {
            announcement.inactive = true
          } else {
-            announcement.read = visibleObject[announcement.id].read
+            announcement.read = visibleAnnouncement.read
          }
        })