Updated default values

changelog.d/add-apng.add

@@ -1 +0,0 @@
-Make Pleroma FE to also view apng (Animated PNG) attachment.

changelog.d/double-notifications.fix

@@ -1 +0,0 @@
-Fix native notifications appearing as many times as there are open tabs. Clicking on notification will focus last focused tab.

changelog.d/focus-clear.add

@@ -1 +0,0 @@
-Focusing into a tab clears all current desktop notifications

changelog.d/mobile-chrome-notifs.fix

@@ -1 +0,0 @@
-Fixed error that appeared on mobile Chrome(ium) (and derivatives) when native notifications are allowed

changelog.d/mobile-drawer-notifications.change

@@ -1 +0,0 @@
-Added option to not mark all notifications when closing notifications drawer on mobile, this creates a new button to mark all as seen.

changelog.d/more-notification-types-setting.fix

@@ -1 +0,0 @@
-Fixed being unable to set notification visibility for reports and follow requests

changelog.d/native-filtering.add

@@ -1 +0,0 @@
-Added option to toggle what notification types appear in native notifications, by default less important ones (likes, repeats, etc) will no longer show up in native notifications.

changelog.d/native-notifications.add

@@ -1 +0,0 @@
-Native notifications now also have "badge" property that matches instance's favicon (visible in Android Chromium at least)

changelog.d/noninteractive-ignore-read.add

@@ -1 +0,0 @@
-Added option to treat non-interactive notifications (likes, repeats et all) as seen for visual purposes (no read mark, ignored in counters, still can show in native notifications)

changelog.d/notification-read.add

@@ -1 +0,0 @@
-Interacting (opening reply box etc) or simply clicking on non-interactive notifications now marks them as read. Clicking on native notifications for non-interactive ones also marks them as seen.

changelog.d/notifications-sorting.change

@@ -1 +0,0 @@
-Notifications are no longer sorted by "seen" status since interacting with them can change their read status and makes UI jumpy. Old behavior can be restored in settings.

changelog.d/serviceworkers.change

@@ -1 +0,0 @@
-Notifications are now shown through a serviceworker (since mobile chrome does not allow them otherwise), it's always enabled, even if previously we only enabled it for WebPush notifications only. If you don't like websites "running" while closed, check how to disable them in your browser. Old way to show notifications will be used as a fallback but might not have all the new features.

changelog.d/unreads-sync.fix

@@ -1 +0,0 @@
-unread notifications should now properly catch up (eventually) in polling mode

changelog.d/video-poster.fix

@@ -1 +0,0 @@
-Video posters on Safari

changelog.d/web-push-always.add

@@ -1 +0,0 @@
-Added option to always "show" notifications when using web push for better compatibility with some browsers (chrome, edge, safari)

package.json

@@ -25,7 +25,7 @@
     "@kazvmoe-infra/pinch-zoom-element": "1.2.0",
     "@kazvmoe-infra/unicode-emoji-json": "0.4.0",
     "@ruffle-rs/ruffle": "0.1.0-nightly.2022.7.12",
-    "@vuelidate/core": "2.0.3",
+    "@vuelidate/core": "2.0.2",
     "@vuelidate/validators": "2.0.0",
     "body-scroll-lock": "3.1.5",
     "chromatism": "3.0.0",

src/boot/after_store.js

@@ -16,7 +16,6 @@ import backendInteractorService from '../services/backend_interactor_service/bac
 import { CURRENT_VERSION } from '../services/theme_data/theme_data.service.js'
 import { applyTheme, applyConfig } from '../services/style_setter/style_setter.js'
 import FaviconService from '../services/favicon_service/favicon_service.js'
-import { initServiceWorker, updateFocus } from '../services/sw/sw.js'
 
 let staticInitialResults = null
 
@@ -345,9 +344,6 @@ const afterStoreSetup = async ({ store, i18n }) => {
   store.dispatch('setLayoutHeight', windowHeight())
 
   FaviconService.initFaviconService()
-  initServiceWorker(store)
-
-  window.addEventListener('focus', () => updateFocus())
 
   const overrides = window.___pleromafe_dev_overrides || {}
   const server = (typeof overrides.target !== 'undefined') ? overrides.target : window.location.origin

src/components/mobile_nav/mobile_nav.js

@@ -14,8 +14,7 @@ import {
   faBell,
   faBars,
   faArrowUp,
-  faMinus,
+  faMinus
-  faCheckDouble
 } from '@fortawesome/free-solid-svg-icons'
 
 library.add(
@@ -23,8 +22,7 @@ library.add(
   faBell,
   faBars,
   faArrowUp,
-  faMinus,
+  faMinus
-  faCheckDouble
 )
 
 const MobileNav = {
@@ -57,12 +55,6 @@ const MobileNav = {
     unseenNotificationsCount () {
       return this.unseenNotifications.length + countExtraNotifications(this.$store)
     },
-    unseenCount () {
-      return this.unseenNotifications.length
-    },
-    unseenCountBadgeText () {
-      return `${this.unseenCount ? this.unseenCount : ''}`
-    },
     hideSitename () { return this.$store.state.instance.hideSitename },
     sitename () { return this.$store.state.instance.name },
     isChat () {
@@ -75,9 +67,6 @@ const MobileNav = {
     shouldConfirmLogout () {
       return this.$store.getters.mergedConfig.modalOnLogout
     },
-    closingDrawerMarksAsSeen () {
-      return this.$store.getters.mergedConfig.closingDrawerMarksAsSeen
-    },
     ...mapGetters(['unreadChatCount'])
   },
   methods: {
@@ -92,7 +81,7 @@ const MobileNav = {
         // make sure to mark notifs seen only when the notifs were open and not
         // from close-calls.
         this.notificationsOpen = false
-        if (markRead && this.closingDrawerMarksAsSeen) {
+        if (markRead) {
           this.markNotificationsAsSeen()
         }
       }
@@ -128,6 +117,7 @@ const MobileNav = {
       this.hideConfirmLogout()
     },
     markNotificationsAsSeen () {
+      // this.$refs.notifications.markAsSeen()
       this.$store.dispatch('markNotificationsAsSeen')
     },
     onScroll ({ target: { scrollTop, clientHeight, scrollHeight } }) {

src/components/mobile_nav/mobile_nav.vue

@@ -50,13 +50,7 @@
       @touchmove.stop="notificationsTouchMove"
     >
       <div class="mobile-notifications-header">
-        <span class="title">
+        <span class="title">{{ $t('notifications.notifications') }}</span>
-          {{ $t('notifications.notifications') }}
-          <span
-            v-if="unseenCountBadgeText"
-            class="badge badge-notification unseen-count"
-          >{{ unseenCountBadgeText }}</span>
-        </span>
         <span class="spacer" />
         <button
           v-if="notificationsAtTop"
@@ -72,17 +66,6 @@
             />
           </FALayers>
         </button>
-        <button
-          v-if="!closingDrawerMarksAsSeen"
-          class="button-unstyled mobile-nav-button"
-          :title="$t('nav.mobile_notifications_mark_as_seen')"
-          @click.stop.prevent="markNotificationsAsSeen()"
-        >
-          <FAIcon
-            class="fa-scale-110 fa-old-padding"
-            icon="check-double"
-          />
-        </button>
         <button
           class="button-unstyled mobile-nav-button"
           :title="$t('nav.mobile_notifications_close')"

src/components/notification/notification.js

@@ -50,7 +50,6 @@ const Notification = {
     }
   },
   props: ['notification'],
-  emits: ['interacted'],
   components: {
     StatusContent,
     UserAvatar,
@@ -73,9 +72,6 @@ const Notification = {
     getUser (notification) {
       return this.$store.state.users.usersObject[notification.from_profile.id]
     },
-    interacted () {
-      this.$emit('interacted')
-    },
     toggleMute () {
       this.unmuted = !this.unmuted
     },
@@ -99,7 +95,6 @@ const Notification = {
       }
     },
     doApprove () {
-      this.$emit('interacted')
       this.$store.state.api.backendInteractor.approveUser({ id: this.user.id })
       this.$store.dispatch('removeFollowRequest', this.user)
       this.$store.dispatch('markSingleNotificationAsSeen', { id: this.notification.id })
@@ -119,7 +114,6 @@ const Notification = {
       }
     },
     doDeny () {
-      this.$emit('interacted')
       this.$store.state.api.backendInteractor.denyUser({ id: this.user.id })
         .then(() => {
           this.$store.dispatch('dismissNotificationLocal', { id: this.notification.id })

src/components/notification/notification.vue

@@ -6,7 +6,6 @@
       class="Notification"
       :compact="true"
       :statusoid="notification.status"
-      @interacted="interacted"
     />
   </article>
   <article v-else>
@@ -249,7 +248,7 @@
           <StatusContent
             :class="{ faint: !statusExpanded }"
             :compact="!statusExpanded"
-            :status="notification.status"
+            :status="notification.action"
           />
         </template>
       </div>

src/components/notifications/notifications.js

@@ -8,8 +8,7 @@ import {
   notificationsFromStore,
   filteredNotificationsFromStore,
   unseenNotificationsFromStore,
-  countExtraNotifications,
+  countExtraNotifications
-  ACTIONABLE_NOTIFICATION_TYPES
 } from '../../services/notification_utils/notification_utils.js'
 import FaviconService from '../../services/favicon_service/favicon_service.js'
 import { library } from '@fortawesome/fontawesome-svg-core'
@@ -66,20 +65,13 @@ const Notifications = {
       return notificationsFromStore(this.$store)
     },
     error () {
-      return this.$store.state.notifications.error
+      return this.$store.state.statuses.notifications.error
     },
     unseenNotifications () {
       return unseenNotificationsFromStore(this.$store)
     },
     filteredNotifications () {
-      if (this.unseenAtTop) {
-        return [
-          ...filteredNotificationsFromStore(this.$store).filter(n => this.shouldShowUnseen(n)),
-          ...filteredNotificationsFromStore(this.$store).filter(n => !this.shouldShowUnseen(n))
-        ]
-      } else {
       return filteredNotificationsFromStore(this.$store, this.filterMode)
-      }
     },
     unseenCountBadgeText () {
       return `${this.unseenCount ? this.unseenCount : ''}${this.extraNotificationsCount ? '*' : ''}`
@@ -87,7 +79,6 @@ const Notifications = {
     unseenCount () {
       return this.unseenNotifications.length
     },
-    ignoreInactionableSeen () { return this.$store.getters.mergedConfig.ignoreInactionableSeen },
     extraNotificationsCount () {
       return countExtraNotifications(this.$store)
     },
@@ -95,7 +86,7 @@ const Notifications = {
       return this.unseenNotifications.length + (this.unreadChatCount) + this.unreadAnnouncementCount
     },
     loading () {
-      return this.$store.state.notifications.loading
+      return this.$store.state.statuses.notifications.loading
     },
     noHeading () {
       const { layoutType } = this.$store.state.interface
@@ -117,7 +108,6 @@ const Notifications = {
       return this.filteredNotifications.slice(0, this.unseenCount + this.seenToDisplayCount)
     },
     noSticky () { return this.$store.getters.mergedConfig.disableStickyHeaders },
-    unseenAtTop () { return this.$store.getters.mergedConfig.unseenAtTop },
     showExtraNotifications () {
       return !this.noExtra
     },
@@ -164,28 +154,11 @@ const Notifications = {
     scrollToTop () {
       const scrollable = this.scrollerRef
       scrollable.scrollTo({ top: this.$refs.root.offsetTop })
+      // this.$refs.root.scrollIntoView({ behavior: 'smooth', block: 'start' })
     },
     updateScrollPosition () {
       this.showScrollTop = this.$refs.root.offsetTop < this.scrollerRef.scrollTop
     },
-    shouldShowUnseen (notification) {
-      if (notification.seen) return false
-
-      const actionable = ACTIONABLE_NOTIFICATION_TYPES.has(notification.type)
-      return this.ignoreInactionableSeen ? actionable : true
-    },
-    /* "Interacted" really refers to "actionable" notifications that require user input,
-     * everything else (likes/repeats/reacts) cannot be acted and therefore we just clear
-     * the "seen" status upon any clicks on them
-     */
-    notificationClicked (notification) {
-      const { id } = notification
-      this.$store.dispatch('notificationClicked', { id })
-    },
-    notificationInteracted (notification) {
-      const { id } = notification
-      this.$store.dispatch('markSingleNotificationAsSeen', { id })
-    },
     markAsSeen () {
       this.$store.dispatch('markNotificationsAsSeen')
       this.seenToDisplayCount = DEFAULT_SEEN_TO_DISPLAY_COUNT

src/components/notifications/notifications.vue

@@ -66,14 +66,10 @@
             :key="notification.id"
             role="listitem"
             class="notification"
-            :class="{unseen: !minimalMode && shouldShowUnseen(notification)}"
+            :class="{unseen: !minimalMode && !notification.seen}"
-            @click="e => notificationClicked(notification)"
           >
             <div class="notification-overlay" />
-            <notification
+            <notification :notification="notification" />
-              :notification="notification"
-              @interacted="e => notificationInteracted(notification)"
-            />
           </div>
         </div>
         <div class="panel-footer">

src/components/quick_view_settings/quick_view_settings.js

@@ -52,6 +52,7 @@ const QuickViewSettings = {
       get () { return this.mergedConfig.mentionLinkShowAvatar },
       set () {
         const value = !this.showUserAvatars
+        console.log(value)
         this.$store.dispatch('setOption', { name: 'mentionLinkShowAvatar', value })
       }
     },

src/components/report/report.js

@@ -16,6 +16,7 @@ const Report = {
   },
   computed: {
     report () {
+      console.log(this.$store.state.reports.reports[this.reportId] || {})
       return this.$store.state.reports.reports[this.reportId] || {}
     },
     state: {

src/components/settings_modal/settings_modal.scss

@@ -3,10 +3,6 @@
 .settings-modal {
   overflow: hidden;
 
-  h4 {
-    margin-bottom: 0.5em;
-  }
-
   .setting-list,
   .option-list {
     list-style-type: none;
@@ -19,14 +15,6 @@
     .suboptions {
       margin-top: 0.3em;
     }
-
-    &.two-column {
-      column-count: 2;
-
-      > li {
-        break-inside: avoid;
-      }
-    }
   }
 
   .setting-description {

src/components/settings_modal/tabs/notifications_tab.js

@@ -16,10 +16,6 @@ const NotificationsTab = {
     user () {
       return this.$store.state.users.currentUser
     },
-    canReceiveReports () {
-      if (!this.user) { return false }
-      return this.user.privileges.includes('reports_manage_reports')
-    },
     ...SharedComputedObject()
   },
   methods: {

src/components/settings_modal/tabs/notifications_tab.vue

@@ -1,30 +1,5 @@
 <template>
   <div :label="$t('settings.notifications')">
-    <div class="setting-item">
-      <h2>{{ $t('settings.notification_setting_annoyance') }}</h2>
-      <ul class="setting-list">
-        <li>
-          <BooleanSetting path="closingDrawerMarksAsSeen">
-            {{ $t('settings.notification_setting_drawer_marks_as_seen') }}
-          </BooleanSetting>
-        </li>
-        <li>
-          <BooleanSetting path="ignoreInactionableSeen">
-            {{ $t('settings.notification_setting_ignore_inactionable_seen') }}
-          </BooleanSetting>
-          <div>
-            <small>
-              {{ $t('settings.notification_setting_ignore_inactionable_seen_tip') }}
-            </small>
-          </div>
-        </li>
-        <li>
-          <BooleanSetting path="unseenAtTop" expert="1">
-            {{ $t('settings.notification_setting_unseen_at_top') }}
-          </BooleanSetting>
-        </li>
-      </ul>
-    </div>
     <div class="setting-item">
       <h2>{{ $t('settings.notification_setting_filters') }}</h2>
       <ul class="setting-list">
@@ -36,145 +11,44 @@
             {{ $t('settings.notification_setting_block_from_strangers') }}
           </BooleanSetting>
         </li>
-        <li>
+        <li class="select-multiple">
-          <h3> {{ $t('settings.notification_visibility') }}</h3>
+          <span class="label">{{ $t('settings.notification_visibility') }}</span>
-          <p v-if="expertLevel > 0">{{ $t('settings.notification_setting_filters_chrome_push') }}</p>
+          <ul class="option-list">
-          <ul class="setting-list two-column">
-            <li>
-              <h4> {{ $t('settings.notification_visibility_mentions') }}</h4>
-              <ul class="setting-list">
-                <li>
-                  <BooleanSetting path="notificationVisibility.mentions">
-                    {{ $t('settings.notification_visibility_in_column') }}
-                  </BooleanSetting>
-                </li>
-                <li>
-                  <BooleanSetting path="notificationNative.mentions">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_likes') }}</h4>
-              <ul class="setting-list">
             <li>
               <BooleanSetting path="notificationVisibility.likes">
-                    {{ $t('settings.notification_visibility_in_column') }}
+                {{ $t('settings.notification_visibility_likes') }}
               </BooleanSetting>
             </li>
-                <li>
-                  <BooleanSetting path="notificationNative.likes">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_repeats') }}</h4>
-              <ul class="setting-list">
             <li>
               <BooleanSetting path="notificationVisibility.repeats">
-                    {{ $t('settings.notification_visibility_in_column') }}
+                {{ $t('settings.notification_visibility_repeats') }}
               </BooleanSetting>
             </li>
-                <li>
-                  <BooleanSetting path="notificationNative.repeats">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_emoji_reactions') }}</h4>
-              <ul class="setting-list">
-                <li>
-                  <BooleanSetting path="notificationVisibility.emojiReactions">
-                    {{ $t('settings.notification_visibility_in_column') }}
-                  </BooleanSetting>
-                </li>
-                <li>
-                  <BooleanSetting path="notificationNative.emojiReactions">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_follows') }}</h4>
-              <ul class="setting-list">
             <li>
               <BooleanSetting path="notificationVisibility.follows">
-                    {{ $t('settings.notification_visibility_in_column') }}
+                {{ $t('settings.notification_visibility_follows') }}
               </BooleanSetting>
             </li>
             <li>
-                  <BooleanSetting path="notificationNative.follows">
+              <BooleanSetting path="notificationVisibility.mentions">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
+                {{ $t('settings.notification_visibility_mentions') }}
               </BooleanSetting>
             </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_follow_requests') }}</h4>
-              <ul class="setting-list">
-                <li>
-                  <BooleanSetting path="notificationVisibility.followRequest">
-                    {{ $t('settings.notification_visibility_in_column') }}
-                  </BooleanSetting>
-                </li>
-                <li>
-                  <BooleanSetting path="notificationNative.followRequest">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_moves') }}</h4>
-              <ul class="setting-list">
             <li>
               <BooleanSetting path="notificationVisibility.moves">
-                    {{ $t('settings.notification_visibility_in_column') }}
+                {{ $t('settings.notification_visibility_moves') }}
               </BooleanSetting>
             </li>
             <li>
-                  <BooleanSetting path="notificationNative.moves">
+              <BooleanSetting path="notificationVisibility.emojiReactions">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
+                {{ $t('settings.notification_visibility_emoji_reactions') }}
               </BooleanSetting>
             </li>
-              </ul>
-            </li>
-            <li>
-              <h4> {{ $t('settings.notification_visibility_polls') }}</h4>
-              <ul class="setting-list">
             <li>
               <BooleanSetting path="notificationVisibility.polls">
-                    {{ $t('settings.notification_visibility_in_column') }}
+                {{ $t('settings.notification_visibility_polls') }}
               </BooleanSetting>
             </li>
-                <li>
-                  <BooleanSetting path="notificationNative.polls">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
-            <li v-if="canReceiveReports">
-              <h4> {{ $t('settings.notification_visibility_reports') }}</h4>
-              <ul class="setting-list">
-                <li>
-                  <BooleanSetting path="notificationVisibility.reports">
-                    {{ $t('settings.notification_visibility_in_column') }}
-                  </BooleanSetting>
-                </li>
-                <li>
-                  <BooleanSetting path="notificationNative.reports">
-                    {{ $t('settings.notification_visibility_native_notifications') }}
-                  </BooleanSetting>
-                </li>
-              </ul>
-            </li>
           </ul>
         </li>
         <li>
@@ -234,21 +108,6 @@
           >
             {{ $t('settings.enable_web_push_notifications') }}
           </BooleanSetting>
-          <ul class="setting-list suboptions">
-            <li>
-              <BooleanSetting
-                path="webPushAlwaysShowNotifications"
-                :disabled="!mergedConfig.webPushNotifications"
-              >
-                {{ $t('settings.enable_web_push_always_show') }}
-              </BooleanSetting>
-              <div :class="{ faint: !mergedConfig.webPushNotifications }">
-                <small>
-                  {{ $t('settings.enable_web_push_always_show_tip') }}
-                </small>
-              </div>
-            </li>
-          </ul>
         </li>
         <li>
           <BooleanSetting

src/components/settings_modal/tabs/theme_tab/theme_tab.js

@@ -755,6 +755,7 @@ export default {
     selected () {
       this.selectedTheme = Object.entries(this.availableStyles).find(([k, s]) => {
         if (Array.isArray(s)) {
+          console.log(s[0] === this.selected, this.selected)
           return s[0] === this.selected
         } else {
           return s.name === this.selected

src/components/status/status.js

@@ -154,7 +154,6 @@ const Status = {
     'controlledSetMediaPlaying',
     'dive'
   ],
-  emits: ['interacted'],
   data () {
     return {
       uncontrolledReplying: false,
@@ -443,11 +442,9 @@ const Status = {
       this.error = error
     },
     clearError () {
-      this.$emit('interacted')
       this.error = undefined
     },
     toggleReplying () {
-      this.$emit('interacted')
       controlledOrUncontrolledToggle(this, 'replying')
     },
     gotoOriginal (id) {

src/components/status/status.vue

@@ -531,17 +531,14 @@
               :visibility="status.visibility"
               :logged-in="loggedIn"
               :status="status"
-              @click="$emit('interacted')"
             />
             <favorite-button
               :logged-in="loggedIn"
               :status="status"
-              @click="$emit('interacted')"
             />
             <ReactButton
               v-if="loggedIn"
               :status="status"
-              @click="$emit('interacted')"
             />
             <extra-buttons
               :status="status"

src/components/video_attachment/video_attachment.vue

@@ -2,7 +2,7 @@
   <video
     class="video"
     preload="metadata"
-    :src="attachment.url + '#t=0.5'"
+    :src="attachment.url"
     :loop="loopVideo"
     :controls="controls"
     :alt="attachment.description"

src/i18n/en.json

@@ -189,7 +189,6 @@
     "mobile_notifications": "Open notifications",
     "mobile_notifications": "Open notifications (there are unread ones)",
     "mobile_notifications_close": "Close notifications",
-    "mobile_notifications_mark_as_seen": "Mark all as seen",
     "announcements": "Announcements"
   },
   "notifications": {
@@ -562,14 +561,10 @@
     "posts": "Posts",
     "user_profiles": "User Profiles",
     "notification_visibility": "Types of notifications to show",
-    "notification_visibility_in_column": "Show in notifications column/drawer",
-    "notification_visibility_native_notifications": "Show a native notification",
     "notification_visibility_follows": "Follows",
-    "notification_visibility_follow_requests": "Follow requests",
     "notification_visibility_likes": "Favorites",
     "notification_visibility_mentions": "Mentions",
     "notification_visibility_repeats": "Repeats",
-    "notification_visibility_reports": "Reports",
     "notification_visibility_moves": "User Migrates",
     "notification_visibility_emoji_reactions": "Reactions",
     "notification_visibility_polls": "Ends of polls you voted in",
@@ -693,21 +688,13 @@
     "greentext": "Meme arrows",
     "show_yous": "Show (You)s",
     "notifications": "Notifications",
-    "notification_setting_annoyance": "Annoyance",
-    "notification_setting_drawer_marks_as_seen": "Closing drawer (mobile) marks all notifications as read",
-    "notification_setting_ignore_inactionable_seen": "Ignore read state of inactionable notifications (likes, repeats etc)",
-    "notification_setting_ignore_inactionable_seen_tip": "This will not actually mark those notifications as read, and you'll still get desktop notifications about them if you chose so",
-    "notification_setting_unseen_at_top": "Show unread notifications above others",
     "notification_setting_filters": "Filters",
-    "notification_setting_filters_chrome_push": "On some browsers (chrome) it might be impossible to completely filter out notifications by type when they arrive by Push",
     "notification_setting_block_from_strangers": "Block notifications from users who you do not follow",
     "notification_setting_privacy": "Privacy",
     "notification_setting_hide_notification_contents": "Hide the sender and contents of push notifications",
     "notification_mutes": "To stop receiving notifications from a specific user, use a mute.",
     "notification_blocks": "Blocking a user stops all notifications as well as unsubscribes them.",
     "enable_web_push_notifications": "Enable web push notifications",
-    "enable_web_push_always_show": "Always show web push notifications",
-    "enable_web_push_always_show_tip": "Some browsers (Chromium, Chrome) require that push messages always result in a notification, otherwise generic 'Website was updated in background' is shown, enable this to prevent this notification from showing, as Chrome seem to hide push notifications if tab is in focus. Can result in showing duplicate notifications on other browsers.",
     "more_settings": "More settings",
     "style": {
       "switcher": {

src/lib/persisted_state.js

@@ -38,7 +38,7 @@ export default function createPersistedState ({
   },
   setState = (key, state, storage) => {
     if (!loaded) {
-      console.info('waiting for old state to be loaded...')
+      console.log('waiting for old state to be loaded...')
       return Promise.resolve()
     } else {
       return storage.setItem(key, state)
@@ -65,7 +65,7 @@ export default function createPersistedState ({
         }
         loaded = true
       } catch (e) {
-        console.error("Couldn't load state")
+        console.log("Couldn't load state")
         console.error(e)
         loaded = true
       }
@@ -86,8 +86,8 @@ export default function createPersistedState ({
               })
           }
         } catch (e) {
-          console.error("Couldn't persist state:")
+          console.log("Couldn't persist state:")
-          console.error(e)
+          console.log(e)
         }
       })
     }

src/main.js

@@ -6,7 +6,6 @@ import './lib/event_target_polyfill.js'
 import interfaceModule from './modules/interface.js'
 import instanceModule from './modules/instance.js'
 import statusesModule from './modules/statuses.js'
-import notificationsModule from './modules/notifications.js'
 import listsModule from './modules/lists.js'
 import usersModule from './modules/users.js'
 import apiModule from './modules/api.js'
@@ -79,7 +78,6 @@ const persistedStateOptions = {
       // TODO refactor users/statuses modules, they depend on each other
       users: usersModule,
       statuses: statusesModule,
-      notifications: notificationsModule,
       lists: listsModule,
       api: apiModule,
       config: configModule,

src/modules/adminSettings.js

@@ -105,6 +105,7 @@ const adminSettingsStorage = {
         }
         set(config, path, convert(c.value))
       })
+      console.log(config[':pleroma'])
       commit('updateAdminSettings', { config, modifiedPaths })
       commit('resetAdminDraft')
     },
@@ -122,6 +123,7 @@ const adminSettingsStorage = {
 
       const descriptions = {}
       backendDescriptions.forEach(d => convert(d, '', descriptions))
+      console.log(descriptions[':pleroma']['Pleroma.Captcha'])
       commit('updateAdminDescriptions', { descriptions })
     },
 

src/modules/config.js

@@ -66,20 +66,7 @@ export const defaultState = {
     chatMention: true,
     polls: true
   },
-  notificationNative: {
-    follows: true,
-    mentions: true,
-    likes: false,
-    repeats: false,
-    moves: false,
-    emojiReactions: false,
-    followRequest: true,
-    reports: true,
-    chatMention: true,
-    polls: true
-  },
   webPushNotifications: false,
-  webPushAlwaysShowNotifications: false,
   muteWords: [],
   highlight: {},
   interfaceLanguage: browserLocale,
@@ -137,10 +124,7 @@ export const defaultState = {
   showAnnouncementsInExtraNotifications: undefined, // instance default
   showFollowRequestsInExtraNotifications: undefined, // instance default
   maxDepthInThread: undefined, // instance default
-  autocompleteSelect: undefined, // instance default
+  autocompleteSelect: undefined // instance default
-  closingDrawerMarksAsSeen: undefined, // instance default
-  unseenAtTop: undefined, // instance default
-  ignoreInactionableSeen: undefined // instance default
 }
 
 // caching the instance default properties

src/modules/instance.js

@@ -110,9 +110,6 @@ const defaultState = {
   showFollowRequestsInExtraNotifications: true,
   maxDepthInThread: 6,
   autocompleteSelect: false,
-  closingDrawerMarksAsSeen: true,
-  unseenAtTop: false,
-  ignoreInactionableSeen: false,
 
   // Nasty stuff
   customEmoji: [],

src/modules/notifications.js

@@ -1,169 +0,0 @@
-import apiService from '../services/api/api.service.js'
-
-import {
-  isStatusNotification,
-  isValidNotification,
-  maybeShowNotification
-} from '../services/notification_utils/notification_utils.js'
-
-import {
-  closeDesktopNotification,
-  closeAllDesktopNotifications
-} from '../services/desktop_notification_utils/desktop_notification_utils.js'
-
-const emptyNotifications = () => ({
-  desktopNotificationSilence: true,
-  maxId: 0,
-  minId: Number.POSITIVE_INFINITY,
-  data: [],
-  idStore: {},
-  loading: false
-})
-
-export const defaultState = () => ({
-  ...emptyNotifications()
-})
-
-export const notifications = {
-  state: defaultState(),
-  mutations: {
-    addNewNotifications (state, { notifications }) {
-      notifications.forEach(notification => {
-        state.data.push(notification)
-        state.idStore[notification.id] = notification
-      })
-    },
-    clearNotifications (state) {
-      state = emptyNotifications()
-    },
-    updateNotificationsMinMaxId (state, id) {
-      state.maxId = id > state.maxId ? id : state.maxId
-      state.minId = id < state.minId ? id : state.minId
-    },
-    setNotificationsLoading (state, { value }) {
-      state.loading = value
-    },
-    setNotificationsSilence (state, { value }) {
-      state.desktopNotificationSilence = value
-    },
-    markNotificationsAsSeen (state) {
-      state.data.forEach((notification) => {
-        notification.seen = true
-      })
-    },
-    markSingleNotificationAsSeen (state, { id }) {
-      const notification = state.idStore[id]
-      if (notification) notification.seen = true
-    },
-    dismissNotification (state, { id }) {
-      state.data = state.data.filter(n => n.id !== id)
-      delete state.idStore[id]
-    },
-    updateNotification (state, { id, updater }) {
-      const notification = state.idStore[id]
-      notification && updater(notification)
-    }
-  },
-  actions: {
-    addNewNotifications (store, { notifications, older }) {
-      const { commit, dispatch, state, rootState } = store
-      const validNotifications = notifications.filter((notification) => {
-        // If invalid notification, update ids but don't add it to store
-        if (!isValidNotification(notification)) {
-          console.error('Invalid notification:', notification)
-          commit('updateNotificationsMinMaxId', notification.id)
-          return false
-        }
-        return true
-      })
-
-      const statusNotifications = validNotifications.filter(notification => isStatusNotification(notification.type) && notification.status)
-
-      // Synchronous commit to add all the statuses
-      commit('addNewStatuses', { statuses: statusNotifications.map(notification => notification.status) })
-
-      // Update references to statuses in notifications to ones in the store
-      statusNotifications.forEach(notification => {
-        const id = notification.status.id
-        const referenceStatus = rootState.statuses.allStatusesObject[id]
-
-        if (referenceStatus) {
-          notification.status = referenceStatus
-        }
-      })
-
-      validNotifications.forEach(notification => {
-        if (notification.type === 'pleroma:report') {
-          dispatch('addReport', notification.report)
-        }
-
-        if (notification.type === 'pleroma:emoji_reaction') {
-          dispatch('fetchEmojiReactionsBy', notification.status.id)
-        }
-
-        // Only add a new notification if we don't have one for the same action
-        // eslint-disable-next-line no-prototype-builtins
-        if (!state.idStore.hasOwnProperty(notification.id)) {
-          commit('updateNotificationsMinMaxId', notification.id)
-          commit('addNewNotifications', { notifications: [notification] })
-
-          maybeShowNotification(store, notification)
-        } else if (notification.seen) {
-          state.idStore[notification.id].seen = true
-        }
-      })
-    },
-    notificationClicked ({ state, dispatch }, { id }) {
-      const notification = state.idStore[id]
-      const { type, seen } = notification
-
-      if (!seen) {
-        switch (type) {
-          case 'mention':
-          case 'pleroma:report':
-          case 'follow_request':
-            break
-          default:
-            dispatch('markSingleNotificationAsSeen', { id })
-        }
-      }
-    },
-    setNotificationsLoading ({ rootState, commit }, { value }) {
-      commit('setNotificationsLoading', { value })
-    },
-    setNotificationsSilence ({ rootState, commit }, { value }) {
-      commit('setNotificationsSilence', { value })
-    },
-    markNotificationsAsSeen ({ rootState, state, commit }) {
-      commit('markNotificationsAsSeen')
-      apiService.markNotificationsAsSeen({
-        id: state.maxId,
-        credentials: rootState.users.currentUser.credentials
-      }).then(() => {
-        closeAllDesktopNotifications(rootState)
-      })
-    },
-    markSingleNotificationAsSeen ({ rootState, commit }, { id }) {
-      commit('markSingleNotificationAsSeen', { id })
-      apiService.markNotificationsAsSeen({
-        single: true,
-        id,
-        credentials: rootState.users.currentUser.credentials
-      }).then(() => {
-        closeDesktopNotification(rootState, { id })
-      })
-    },
-    dismissNotificationLocal ({ rootState, commit }, { id }) {
-      commit('dismissNotification', { id })
-    },
-    dismissNotification ({ rootState, commit }, { id }) {
-      commit('dismissNotification', { id })
-      rootState.api.backendInteractor.dismissNotification({ id })
-    },
-    updateNotification ({ rootState, commit }, { id, updater }) {
-      commit('updateNotification', { id, updater })
-    }
-  }
-}
-
-export default notifications

src/modules/serverSideStorage.js

@@ -419,6 +419,7 @@ const serverSideStorage = {
   actions: {
     pushServerSideStorage ({ state, rootState, commit }, { force = false } = {}) {
       const needPush = state.dirty || force
+      console.log(needPush)
       if (!needPush) return
       commit('updateCache', { username: rootState.users.currentUser.fqn })
       const params = { pleroma_settings_store: { 'pleroma-fe': state.cache } }

src/modules/statuses.js

@@ -12,6 +12,11 @@ import {
   isArray,
   omitBy
 } from 'lodash'
+import {
+  isStatusNotification,
+  isValidNotification,
+  maybeShowNotification
+} from '../services/notification_utils/notification_utils.js'
 import apiService from '../services/api/api.service.js'
 
 const emptyTl = (userId = 0) => ({
@@ -31,12 +36,22 @@ const emptyTl = (userId = 0) => ({
   flushMarker: 0
 })
 
+const emptyNotifications = () => ({
+  desktopNotificationSilence: true,
+  maxId: 0,
+  minId: Number.POSITIVE_INFINITY,
+  data: [],
+  idStore: {},
+  loading: false
+})
+
 export const defaultState = () => ({
   allStatuses: [],
   scrobblesNextFetch: {},
   allStatusesObject: {},
   conversationsObject: {},
   maxId: 0,
+  notifications: emptyNotifications(),
   favorites: new Set(),
   timelines: {
     mentions: emptyTl(),
@@ -139,6 +154,22 @@ const addStatusToGlobalStorage = (state, data) => {
   return result
 }
 
+// Remove status from the global storages (arrays and objects maintaining statuses) except timelines
+const removeStatusFromGlobalStorage = (state, status) => {
+  remove(state.allStatuses, { id: status.id })
+
+  // TODO: Need to remove from allStatusesObject?
+
+  // Remove possible notification
+  remove(state.notifications.data, ({ action: { id } }) => id === status.id)
+
+  // Remove from conversation
+  const conversationId = status.statusnet_conversation_id
+  if (state.conversationsObject[conversationId]) {
+    remove(state.conversationsObject[conversationId], { id: status.id })
+  }
+}
+
 const addNewStatuses = (state, { statuses, showImmediately = false, timeline, user = {}, noIdUpdate = false, userId, pagination = {} }) => {
   // Sanity check
   if (!isArray(statuses)) {
@@ -272,6 +303,20 @@ const addNewStatuses = (state, { statuses, showImmediately = false, timeline, us
         favoriteStatus(favorite)
       }
     },
+    deletion: (deletion) => {
+      const uri = deletion.uri
+      const status = find(allStatuses, { uri })
+      if (!status) {
+        return
+      }
+
+      removeStatusFromGlobalStorage(state, status)
+
+      if (timeline) {
+        remove(timelineObject.statuses, { uri })
+        remove(timelineObject.visibleStatuses, { uri })
+      }
+    },
     follow: (follow) => {
       // NOOP, it is known status but we don't do anything about it for now
     },
@@ -293,6 +338,52 @@ const addNewStatuses = (state, { statuses, showImmediately = false, timeline, us
   }
 }
 
+const updateNotificationsMinMaxId = (state, notification) => {
+  state.notifications.maxId = notification.id > state.notifications.maxId
+    ? notification.id
+    : state.notifications.maxId
+  state.notifications.minId = notification.id < state.notifications.minId
+    ? notification.id
+    : state.notifications.minId
+}
+
+const addNewNotifications = (state, { dispatch, notifications, older, visibleNotificationTypes, rootGetters, newNotificationSideEffects }) => {
+  each(notifications, (notification) => {
+    // If invalid notification, update ids but don't add it to store
+    if (!isValidNotification(notification)) {
+      console.error('Invalid notification:', notification)
+      updateNotificationsMinMaxId(state, notification)
+      return
+    }
+
+    if (isStatusNotification(notification.type)) {
+      notification.action = addStatusToGlobalStorage(state, notification.action).item
+      notification.status = notification.status && addStatusToGlobalStorage(state, notification.status).item
+    }
+
+    if (notification.type === 'pleroma:report') {
+      dispatch('addReport', notification.report)
+    }
+
+    if (notification.type === 'pleroma:emoji_reaction') {
+      dispatch('fetchEmojiReactionsBy', notification.status.id)
+    }
+
+    // Only add a new notification if we don't have one for the same action
+    // eslint-disable-next-line no-prototype-builtins
+    if (!state.notifications.idStore.hasOwnProperty(notification.id)) {
+      updateNotificationsMinMaxId(state, notification)
+
+      state.notifications.data.push(notification)
+      state.notifications.idStore[notification.id] = notification
+
+      newNotificationSideEffects(notification)
+    } else if (notification.seen) {
+      state.notifications.idStore[notification.id].seen = true
+    }
+  })
+}
+
 const removeStatus = (state, { timeline, userId }) => {
   const timelineObject = state.timelines[timeline]
   if (userId) {
@@ -305,6 +396,7 @@ const removeStatus = (state, { timeline, userId }) => {
 
 export const mutations = {
   addNewStatuses,
+  addNewNotifications,
   removeStatus,
   showNewStatuses (state, { timeline }) {
     const oldTimeline = (state.timelines[timeline])
@@ -326,6 +418,9 @@ export const mutations = {
     const userId = excludeUserId ? state.timelines[timeline].userId : undefined
     state.timelines[timeline] = emptyTl(userId)
   },
+  clearNotifications (state) {
+    state.notifications = emptyNotifications()
+  },
   setFavorited (state, { status, value }) {
     const newStatus = state.allStatusesObject[status.id]
 
@@ -408,6 +503,31 @@ export const mutations = {
     const newStatus = state.allStatusesObject[id]
     newStatus.nsfw = nsfw
   },
+  setNotificationsLoading (state, { value }) {
+    state.notifications.loading = value
+  },
+  setNotificationsSilence (state, { value }) {
+    state.notifications.desktopNotificationSilence = value
+  },
+  markNotificationsAsSeen (state) {
+    each(state.notifications.data, (notification) => {
+      notification.seen = true
+    })
+  },
+  markSingleNotificationAsSeen (state, { id }) {
+    const notification = find(state.notifications.data, n => n.id === id)
+    if (notification) notification.seen = true
+  },
+  dismissNotification (state, { id }) {
+    state.notifications.data = state.notifications.data.filter(n => n.id !== id)
+  },
+  dismissNotifications (state, { finder }) {
+    state.notifications.data = state.notifications.data.filter(n => finder)
+  },
+  updateNotification (state, { id, updater }) {
+    const notification = find(state.notifications.data, n => n.id === id)
+    notification && updater(notification)
+  },
   queueFlush (state, { timeline, id }) {
     state.timelines[timeline].flushMarker = id
   },
@@ -489,9 +609,23 @@ export const mutations = {
 const statuses = {
   state: defaultState(),
   actions: {
-    addNewStatuses ({ rootState, commit, dispatch, state }, { statuses, showImmediately = false, timeline = false, noIdUpdate = false, userId, pagination }) {
+    addNewStatuses ({ rootState, commit }, { statuses, showImmediately = false, timeline = false, noIdUpdate = false, userId, pagination }) {
       commit('addNewStatuses', { statuses, showImmediately, timeline, noIdUpdate, user: rootState.users.currentUser, userId, pagination })
     },
+    addNewNotifications (store, { notifications, older }) {
+      const { commit, dispatch, rootGetters } = store
+
+      const newNotificationSideEffects = (notification) => {
+        maybeShowNotification(store, notification)
+      }
+      commit('addNewNotifications', { dispatch, notifications, older, rootGetters, newNotificationSideEffects })
+    },
+    setNotificationsLoading ({ rootState, commit }, { value }) {
+      commit('setNotificationsLoading', { value })
+    },
+    setNotificationsSilence ({ rootState, commit }, { value }) {
+      commit('setNotificationsSilence', { value })
+    },
     fetchStatus ({ rootState, dispatch }, id) {
       return rootState.api.backendInteractor.fetchStatus({ id })
         .then((status) => dispatch('addNewStatuses', { statuses: [status] }))
@@ -587,6 +721,31 @@ const statuses = {
     queueFlushAll ({ rootState, commit }) {
       commit('queueFlushAll')
     },
+    markNotificationsAsSeen ({ rootState, commit }) {
+      commit('markNotificationsAsSeen')
+      apiService.markNotificationsAsSeen({
+        id: rootState.statuses.notifications.maxId,
+        credentials: rootState.users.currentUser.credentials
+      })
+    },
+    markSingleNotificationAsSeen ({ rootState, commit }, { id }) {
+      commit('markSingleNotificationAsSeen', { id })
+      apiService.markNotificationsAsSeen({
+        single: true,
+        id,
+        credentials: rootState.users.currentUser.credentials
+      })
+    },
+    dismissNotificationLocal ({ rootState, commit }, { id }) {
+      commit('dismissNotification', { id })
+    },
+    dismissNotification ({ rootState, commit }, { id }) {
+      commit('dismissNotification', { id })
+      rootState.api.backendInteractor.dismissNotification({ id })
+    },
+    updateNotification ({ rootState, commit }, { id, updater }) {
+      commit('updateNotification', { id, updater })
+    },
     fetchFavsAndRepeats ({ rootState, commit }, id) {
       Promise.all([
         rootState.api.backendInteractor.fetchFavoritedByUsers({ id }),

src/modules/users.js

@@ -2,7 +2,7 @@ import backendInteractorService from '../services/backend_interactor_service/bac
 import { windowWidth, windowHeight } from '../services/window_utils/window_utils'
 import oauthApi from '../services/new_api/oauth.js'
 import { compact, map, each, mergeWith, last, concat, uniq, isArray } from 'lodash'
-import { registerPushNotifications, unregisterPushNotifications } from '../services/sw/sw.js'
+import { registerPushNotifications, unregisterPushNotifications } from '../services/push/push.js'
 
 // TODO: Unify with mergeOrAdd in statuses.js
 export const mergeOrAdd = (arr, obj, item) => {
@@ -498,7 +498,7 @@ const users = {
       store.commit('addNewUsers', users)
       store.commit('addNewUsers', targetUsers)
 
-      const notificationsObject = store.rootState.notifications.idStore
+      const notificationsObject = store.rootState.statuses.notifications.idStore
       const relevantNotifications = Object.entries(notificationsObject)
         .filter(([k, val]) => notificationIds.includes(k))
         .map(([k, val]) => val)
@@ -667,7 +667,7 @@ const users = {
             resolve()
           })
           .catch((error) => {
-            console.error(error)
+            console.log(error)
             commit('endLogin')
             reject(new Error('Failed to connect to server, try again'))
           })

src/services/api/api.service.js

@@ -671,7 +671,6 @@ const fetchTimeline = ({
   timeline,
   credentials,
   since = false,
-  minId = false,
   until = false,
   userId = false,
   listId = false,
@@ -706,9 +705,6 @@ const fetchTimeline = ({
     url = url(listId)
   }
 
-  if (minId) {
-    params.push(['min_id', minId])
-  }
   if (since) {
     params.push(['since_id', since])
   }

src/services/desktop_notification_utils/desktop_notification_utils.js

@@ -1,38 +1,9 @@
-import {
-  showDesktopNotification as swDesktopNotification,
-  closeDesktopNotification as swCloseDesktopNotification,
-  isSWSupported
-} from '../sw/sw.js'
-const state = { failCreateNotif: false }
-
 export const showDesktopNotification = (rootState, desktopNotificationOpts) => {
   if (!('Notification' in window && window.Notification.permission === 'granted')) return
-  if (rootState.notifications.desktopNotificationSilence) { return }
+  if (rootState.statuses.notifications.desktopNotificationSilence) { return }
 
-  if (isSWSupported()) {
-    swDesktopNotification(desktopNotificationOpts)
-  } else if (!state.failCreateNotif) {
-    try {
   const desktopNotification = new window.Notification(desktopNotificationOpts.title, desktopNotificationOpts)
+  // Chrome is known for not closing notifications automatically
+  // according to MDN, anyway.
   setTimeout(desktopNotification.close.bind(desktopNotification), 5000)
-    } catch {
-      state.failCreateNotif = true
-    }
-  }
-}
-
-export const closeDesktopNotification = (rootState, { id }) => {
-  if (!('Notification' in window && window.Notification.permission === 'granted')) return
-
-  if (isSWSupported()) {
-    swCloseDesktopNotification({ id })
-  }
-}
-
-export const closeAllDesktopNotifications = (rootState) => {
-  if (!('Notification' in window && window.Notification.permission === 'granted')) return
-
-  if (isSWSupported()) {
-    swCloseDesktopNotification({})
-  }
 }

src/services/entity_normalizer/entity_normalizer.service.js

@@ -439,6 +439,7 @@ export const parseNotification = (data) => {
     output.type = mastoDict[data.type] || data.type
     output.seen = data.pleroma.is_seen
     output.status = isStatusNotification(output.type) ? parseStatus(data.status) : null
+    output.action = output.status // TODO: Refactor, this is unneeded
     output.target = output.type !== 'move'
       ? null
       : parseUser(data.target)

src/services/favicon_service/favicon_service.js

@@ -55,13 +55,10 @@ const createFaviconService = () => {
     })
   }
 
-  const getOriginalFavicons = () => [...favicons]
-
   return {
     initFaviconService,
     clearFaviconBadge,
-    drawFaviconBadge,
+    drawFaviconBadge
-    getOriginalFavicons
   }
 }
 

src/services/file_type/file_type.service.js

@@ -26,7 +26,7 @@ export const fileType = mimetype => {
 }
 
 export const fileTypeExt = url => {
-  if (url.match(/\.(a?png|jpe?g|gif|webp|avif)$/)) {
+  if (url.match(/\.(png|jpe?g|gif|webp|avif)$/)) {
     return 'image'
   }
   if (url.match(/\.(ogv|mp4|webm|mov)$/)) {

src/services/notification_utils/notification_utils.js

@@ -1,36 +1,28 @@
+import { filter, sortBy, includes } from 'lodash'
 import { muteWordHits } from '../status_parser/status_parser.js'
 import { showDesktopNotification } from '../desktop_notification_utils/desktop_notification_utils.js'
 
-import FaviconService from 'src/services/favicon_service/favicon_service.js'
+export const notificationsFromStore = store => store.state.statuses.notifications.data
-
-export const ACTIONABLE_NOTIFICATION_TYPES = new Set(['mention', 'pleroma:report', 'follow_request'])
-
-let cachedBadgeUrl = null
-
-export const notificationsFromStore = store => store.state.notifications.data
 
 export const visibleTypes = store => {
-  // When called from within a module we need rootGetters to access wider scope
+  const rootState = store.rootState || store.state
-  // however when called from a component (i.e. this.$store) we already have wider scope
-  const rootGetters = store.rootGetters || store.getters
-  const { notificationVisibility } = rootGetters.mergedConfig
 
   return ([
-    notificationVisibility.likes && 'like',
+    rootState.config.notificationVisibility.likes && 'like',
-    notificationVisibility.mentions && 'mention',
+    rootState.config.notificationVisibility.mentions && 'mention',
-    notificationVisibility.repeats && 'repeat',
+    rootState.config.notificationVisibility.repeats && 'repeat',
-    notificationVisibility.follows && 'follow',
+    rootState.config.notificationVisibility.follows && 'follow',
-    notificationVisibility.followRequest && 'follow_request',
+    rootState.config.notificationVisibility.followRequest && 'follow_request',
-    notificationVisibility.moves && 'move',
+    rootState.config.notificationVisibility.moves && 'move',
-    notificationVisibility.emojiReactions && 'pleroma:emoji_reaction',
+    rootState.config.notificationVisibility.emojiReactions && 'pleroma:emoji_reaction',
-    notificationVisibility.reports && 'pleroma:report',
+    rootState.config.notificationVisibility.reports && 'pleroma:report',
-    notificationVisibility.polls && 'poll'
+    rootState.config.notificationVisibility.polls && 'poll'
   ].filter(_ => _))
 }
 
-const statusNotifications = new Set(['like', 'mention', 'repeat', 'pleroma:emoji_reaction', 'poll'])
+const statusNotifications = ['like', 'mention', 'repeat', 'pleroma:emoji_reaction', 'poll']
 
-export const isStatusNotification = (type) => statusNotifications.has(type)
+export const isStatusNotification = (type) => includes(statusNotifications, type)
 
 export const isValidNotification = (notification) => {
   if (isStatusNotification(notification.type) && !notification.status) {
@@ -57,57 +49,35 @@ const sortById = (a, b) => {
 
 const isMutedNotification = (store, notification) => {
   if (!notification.status) return
-  const rootGetters = store.rootGetters || store.getters
+  return notification.status.muted || muteWordHits(notification.status, store.rootGetters.mergedConfig.muteWords).length > 0
-  return notification.status.muted || muteWordHits(notification.status, rootGetters.mergedConfig.muteWords).length > 0
 }
 
 export const maybeShowNotification = (store, notification) => {
   const rootState = store.rootState || store.state
-  const rootGetters = store.rootGetters || store.getters
 
   if (notification.seen) return
   if (!visibleTypes(store).includes(notification.type)) return
   if (notification.type === 'mention' && isMutedNotification(store, notification)) return
 
-  const notificationObject = prepareNotificationObject(notification, rootGetters.i18n)
+  const notificationObject = prepareNotificationObject(notification, store.rootGetters.i18n)
   showDesktopNotification(rootState, notificationObject)
 }
 
 export const filteredNotificationsFromStore = (store, types) => {
   // map is just to clone the array since sort mutates it and it causes some issues
-  const sortedNotifications = notificationsFromStore(store).map(_ => _).sort(sortById)
+  let sortedNotifications = notificationsFromStore(store).map(_ => _).sort(sortById)
-  // TODO implement sorting elsewhere and make it optional
+  sortedNotifications = sortBy(sortedNotifications, 'seen')
   return sortedNotifications.filter(
     (notification) => (types || visibleTypes(store)).includes(notification.type)
   )
 }
 
-export const unseenNotificationsFromStore = store => {
+export const unseenNotificationsFromStore = store =>
-  const rootGetters = store.rootGetters || store.getters
+  filter(filteredNotificationsFromStore(store), ({ seen }) => !seen)
-  const ignoreInactionableSeen = rootGetters.mergedConfig.ignoreInactionableSeen
-
-  return filteredNotificationsFromStore(store).filter(({ seen, type }) => {
-    if (!ignoreInactionableSeen) return !seen
-    if (seen) return false
-    return ACTIONABLE_NOTIFICATION_TYPES.has(type)
-  })
-}
 
 export const prepareNotificationObject = (notification, i18n) => {
-  if (cachedBadgeUrl === null) {
-    const favicons = FaviconService.getOriginalFavicons()
-    const favicon = favicons[favicons.length - 1]
-    if (!favicon) {
-      cachedBadgeUrl = 'about:blank'
-    } else {
-      cachedBadgeUrl = favicon.favimg.src
-    }
-  }
-
   const notifObj = {
-    tag: notification.id,
+    tag: notification.id
-    type: notification.type,
-    badge: cachedBadgeUrl
   }
   const status = notification.status
   const title = notification.from_profile.name
@@ -156,16 +126,15 @@ export const prepareNotificationObject = (notification, i18n) => {
 }
 
 export const countExtraNotifications = (store) => {
-  const rootGetters = store.rootGetters || store.getters
+  const mergedConfig = store.getters.mergedConfig
-  const mergedConfig = rootGetters.mergedConfig
 
   if (!mergedConfig.showExtraNotifications) {
     return 0
   }
 
   return [
-    mergedConfig.showChatsInExtraNotifications ? rootGetters.unreadChatCount : 0,
+    mergedConfig.showChatsInExtraNotifications ? store.getters.unreadChatCount : 0,
-    mergedConfig.showAnnouncementsInExtraNotifications ? rootGetters.unreadAnnouncementCount : 0,
+    mergedConfig.showAnnouncementsInExtraNotifications ? store.getters.unreadAnnouncementCount : 0,
-    mergedConfig.showFollowRequestsInExtraNotifications ? rootGetters.followRequestCount : 0
+    mergedConfig.showFollowRequestsInExtraNotifications ? store.getters.followRequestCount : 0
   ].reduce((a, c) => a + c, 0)
 }

src/services/notifications_fetcher/notifications_fetcher.service.js

@@ -21,7 +21,7 @@ const fetchAndUpdate = ({ store, credentials, older = false, since }) => {
   const args = { credentials }
   const { getters } = store
   const rootState = store.rootState || store.state
-  const timelineData = rootState.notifications
+  const timelineData = rootState.statuses.notifications
   const hideMutedPosts = getters.mergedConfig.hideMutedPosts
 
   args.includeTypes = mastoApiNotificationTypes
@@ -49,15 +49,11 @@ const fetchAndUpdate = ({ store, credentials, older = false, since }) => {
     // The normal maxId-check does not tell if older notifications have changed
     const notifications = timelineData.data
     const readNotifsIds = notifications.filter(n => n.seen).map(n => n.id)
-    const unreadNotifsIds = notifications.filter(n => !n.seen).map(n => n.id)
+    const numUnseenNotifs = notifications.length - readNotifsIds.length
-    if (readNotifsIds.length > 0 && readNotifsIds.length > 0) {
+    if (numUnseenNotifs > 0 && readNotifsIds.length > 0) {
-      const minId = Math.min(...unreadNotifsIds) // Oldest known unread notification
+      args.since = Math.max(...readNotifsIds)
-      if (minId !== Infinity) {
-        args.since = false // Don't use since_id since it sorta conflicts with min_id
-        args.minId = minId - 1 // go beyond
       fetchNotifications({ store, args, older })
     }
-    }
 
     return result
   }

src/services/push/push.js

@@ -10,12 +10,8 @@ function urlBase64ToUint8Array (base64String) {
   return Uint8Array.from([...rawData].map((char) => char.charCodeAt(0)))
 }
 
-export function isSWSupported () {
-  return 'serviceWorker' in navigator
-}
-
 function isPushSupported () {
-  return 'PushManager' in window
+  return 'serviceWorker' in navigator && 'PushManager' in window
 }
 
 function getOrCreateServiceWorker () {
@@ -28,7 +24,7 @@ function subscribePush (registration, isEnabled, vapidPublicKey) {
   if (!vapidPublicKey) return Promise.reject(new Error('VAPID public key is not found'))
 
   const subscribeOptions = {
-    userVisibleOnly: false,
+    userVisibleOnly: true,
     applicationServerKey: urlBase64ToUint8Array(vapidPublicKey)
   }
   return registration.pushManager.subscribe(subscribeOptions)
@@ -43,7 +39,7 @@ function unsubscribePush (registration) {
 }
 
 function deleteSubscriptionFromBackEnd (token) {
-  return fetch('/api/v1/push/subscription/', {
+  return window.fetch('/api/v1/push/subscription/', {
     method: 'DELETE',
     headers: {
       'Content-Type': 'application/json',
@@ -82,44 +78,6 @@ function sendSubscriptionToBackEnd (subscription, token, notificationVisibility)
     return responseData
   })
 }
-export async function initServiceWorker (store) {
-  if (!isSWSupported()) return
-  await getOrCreateServiceWorker()
-  navigator.serviceWorker.addEventListener('message', (event) => {
-    const { dispatch } = store
-    const { type, ...rest } = event.data
-
-    switch (type) {
-      case 'notificationClicked':
-        dispatch('notificationClicked', { id: rest.id })
-    }
-  })
-}
-
-export async function showDesktopNotification (content) {
-  if (!isSWSupported) return
-  const { active: sw } = await window.navigator.serviceWorker.getRegistration()
-  if (!sw) return console.error('No serviceworker found!')
-  sw.postMessage({ type: 'desktopNotification', content })
-}
-
-export async function closeDesktopNotification ({ id }) {
-  if (!isSWSupported) return
-  const { active: sw } = await window.navigator.serviceWorker.getRegistration()
-  if (!sw) return console.error('No serviceworker found!')
-  if (id >= 0) {
-    sw.postMessage({ type: 'desktopNotificationClose', content: { id } })
-  } else {
-    sw.postMessage({ type: 'desktopNotificationClose', content: { all: true } })
-  }
-}
-
-export async function updateFocus () {
-  if (!isSWSupported) return
-  const { active: sw } = await window.navigator.serviceWorker.getRegistration()
-  if (!sw) return console.error('No serviceworker found!')
-  sw.postMessage({ type: 'updateFocus' })
-}
 
 export function registerPushNotifications (isEnabled, vapidPublicKey, token, notificationVisibility) {
   if (isPushSupported()) {
@@ -140,8 +98,13 @@ export function unregisterPushNotifications (token) {
         })
         .then(([registration, unsubResult]) => {
           if (!unsubResult) {
-            console.warn('Push subscription cancellation wasn\'t successful')
+            console.warn('Push subscription cancellation wasn\'t successful, killing SW anyway...')
           }
+          return registration.unregister().then((result) => {
+            if (!result) {
+              console.warn('Failed to kill SW')
+            }
+          })
         })
     ]).catch((e) => console.warn(`Failed to disable Web Push Notifications: ${e.message}`))
   }

src/sw.js

@@ -13,10 +13,9 @@ const i18n = createI18n({
   messages
 })
 
-const state = {
+function isEnabled () {
-  lastFocused: null,
+  return localForage.getItem('vuex-lz')
-  notificationIds: new Set(),
+    .then(data => data.config.webPushNotifications)
-  allowedNotificationTypes: null
 }
 
 function getWindowClients () {
@@ -24,46 +23,17 @@ function getWindowClients () {
     .then((clientList) => clientList.filter(({ type }) => type === 'window'))
 }
 
-const setSettings = async () => {
+const setLocale = async () => {
-  const vuexState = await localForage.getItem('vuex-lz')
+  const state = await localForage.getItem('vuex-lz')
-  const locale = vuexState.config.interfaceLanguage || 'en'
+  const locale = state.config.interfaceLanguage || 'en'
   i18n.locale = locale
-  const notificationsNativeArray = Object.entries(vuexState.config.notificationNative)
-  state.webPushAlwaysShowNotifications = vuexState.config.webPushAlwaysShowNotifications
-
-  state.allowedNotificationTypes = new Set(
-    notificationsNativeArray
-      .filter(([k, v]) => v)
-      .map(([k]) => {
-        switch (k) {
-          case 'mentions':
-            return 'mention'
-          case 'likes':
-            return 'like'
-          case 'repeats':
-            return 'repeat'
-          case 'emojiReactions':
-            return 'pleroma:emoji_reaction'
-          case 'reports':
-            return 'pleroma:report'
-          case 'followRequest':
-            return 'follow_request'
-          case 'follows':
-            return 'follow'
-          case 'polls':
-            return 'poll'
-          default:
-            return k
-        }
-      })
-  )
 }
 
-const showPushNotification = async (event) => {
+const maybeShowNotification = async (event) => {
+  const enabled = await isEnabled()
   const activeClients = await getWindowClients()
-  await setSettings()
+  await setLocale()
-  // Only show push notifications if all tabs/windows are closed
+  if (enabled && (activeClients.length === 0)) {
-  if (state.webPushAlwaysShowNotifications || activeClients.length === 0) {
     const data = event.data.json()
 
     const url = `${self.registration.scope}api/v1/notifications/${data.notification_id}`
@@ -73,48 +43,13 @@ const showPushNotification = async (event) => {
 
     const res = prepareNotificationObject(parsedNotification, i18n)
 
-    if (state.webPushAlwaysShowNotifications || state.allowedNotificationTypes.has(parsedNotification.type)) {
+    self.registration.showNotification(res.title, res)
-      return self.registration.showNotification(res.title, res)
   }
-  }
-  return Promise.resolve()
 }
 
 self.addEventListener('push', async (event) => {
   if (event.data) {
-    // Supposedly, we HAVE to return a promise inside waitUntil otherwise it will
+    event.waitUntil(maybeShowNotification(event))
-    // show (extra) notification that website is updated in background
-    event.waitUntil(showPushNotification(event))
-  }
-})
-
-self.addEventListener('message', async (event) => {
-  await setSettings()
-  const { type, content } = event.data
-
-  if (type === 'desktopNotification') {
-    const { title, ...rest } = content
-    const { tag, type } = rest
-    if (state.notificationIds.has(tag)) return
-    state.notificationIds.add(tag)
-    setTimeout(() => state.notificationIds.delete(tag), 10000)
-    if (state.allowedNotificationTypes.has(type)) {
-      self.registration.showNotification(title, rest)
-    }
-  }
-
-  if (type === 'desktopNotificationClose') {
-    const { id, all } = content
-    const search = all ? null : { tag: id }
-    const notifications = await self.registration.getNotifications(search)
-    notifications.forEach(n => n.close())
-  }
-
-  if (type === 'updateFocus') {
-    state.lastFocused = event.source.id
-
-    const notifications = await self.registration.getNotifications()
-    notifications.forEach(n => n.close())
   }
 })
 
@@ -124,14 +59,7 @@ self.addEventListener('notificationclick', (event) => {
   event.waitUntil(getWindowClients().then((list) => {
     for (let i = 0; i < list.length; i++) {
       const client = list[i]
-      client.postMessage({ type: 'notificationClicked', id: event.notification.tag })
+      if (client.url === '/' && 'focus' in client) { return client.focus() }
-    }
-
-    for (let i = 0; i < list.length; i++) {
-      const client = list[i]
-      if (state.lastFocused === null || client.id === state.lastFocused) {
-        if ('focus' in client) return client.focus()
-      }
     }
 
     if (clients.openWindow) return clients.openWindow('/')

test/unit/specs/modules/statuses.spec.js

@@ -77,6 +77,24 @@ describe('Statuses module', () => {
       expect(state.timelines.public.newStatusCount).to.equal(0)
     })
 
+    it('removes statuses by tag on deletion', () => {
+      const state = defaultState()
+      const status = makeMockStatus({ id: '1' })
+      const otherStatus = makeMockStatus({ id: '3' })
+      status.uri = 'xxx'
+      const deletion = makeMockStatus({ id: '2', type: 'deletion' })
+      deletion.text = 'Dolus deleted notice {{tag:gs.smuglo.li,2016-11-18:noticeId=1038007:objectType=note}}.'
+      deletion.uri = 'xxx'
+
+      mutations.addNewStatuses(state, { statuses: [status, otherStatus], showImmediately: true, timeline: 'public' })
+      mutations.addNewStatuses(state, { statuses: [deletion], showImmediately: true, timeline: 'public' })
+
+      expect(state.allStatuses).to.eql([otherStatus])
+      expect(state.timelines.public.statuses).to.eql([otherStatus])
+      expect(state.timelines.public.visibleStatuses).to.eql([otherStatus])
+      expect(state.timelines.public.maxId).to.eql('3')
+    })
+
     it('does not update the maxId when the noIdUpdate flag is set', () => {
       const state = defaultState()
       const status = makeMockStatus({ id: '1' })
@@ -297,4 +315,62 @@ describe('Statuses module', () => {
       expect(state.timelines.user.userId).to.eql(123)
     })
   })
+
+  describe('notifications', () => {
+    it('removes a notification when the notice gets removed', () => {
+      const user = { id: '1' }
+      const state = defaultState()
+      const status = makeMockStatus({ id: '1' })
+      const otherStatus = makeMockStatus({ id: '3' })
+      const mentionedStatus = makeMockStatus({ id: '2' })
+      mentionedStatus.attentions = [user]
+      mentionedStatus.uri = 'xxx'
+      otherStatus.attentions = [user]
+
+      const deletion = makeMockStatus({ id: '4', type: 'deletion' })
+      deletion.text = 'Dolus deleted notice {{tag:gs.smuglo.li,2016-11-18:noticeId=1038007:objectType=note}}.'
+      deletion.uri = 'xxx'
+      const newNotificationSideEffects = () => {}
+      mutations.addNewStatuses(state, { statuses: [status, otherStatus], user })
+      mutations.addNewNotifications(
+        state,
+        {
+          notifications: [{
+            from_profile: { id: '2' },
+            id: '998',
+            type: 'mention',
+            status: otherStatus,
+            action: otherStatus,
+            seen: false
+          }],
+          newNotificationSideEffects
+        })
+
+      expect(state.notifications.data.length).to.eql(1)
+      mutations.addNewNotifications(
+        state,
+        {
+          notifications: [{
+            from_profile: { id: '2' },
+            id: '999',
+            type: 'mention',
+            status: mentionedStatus,
+            action: mentionedStatus,
+            seen: false
+          }],
+          newNotificationSideEffects
+        })
+
+      mutations.addNewStatuses(state, { statuses: [mentionedStatus], user })
+      expect(state.allStatuses.length).to.eql(3)
+      expect(state.notifications.data.length).to.eql(2)
+      expect(state.notifications.data[1].status).to.eql(mentionedStatus)
+      expect(state.notifications.data[1].action).to.eql(mentionedStatus)
+      expect(state.notifications.data[1].type).to.eql('mention')
+
+      mutations.addNewStatuses(state, { statuses: [deletion], user })
+      expect(state.allStatuses.length).to.eql(2)
+      expect(state.notifications.data.length).to.eql(1)
+    })
+  })
 })

test/unit/specs/services/notification_utils/notification_utils.spec.js

@@ -5,6 +5,7 @@ describe('NotificationUtils', () => {
     it('should return sorted notifications with configured types', () => {
       const store = {
         state: {
+          statuses: {
             notifications: {
               data: [
                 {
@@ -25,8 +26,7 @@ describe('NotificationUtils', () => {
               ]
             }
           },
-        getters: {
+          config: {
-          mergedConfig: {
             notificationVisibility: {
               likes: true,
               repeats: true,
@@ -55,6 +55,7 @@ describe('NotificationUtils', () => {
     it('should return only notifications not marked as seen', () => {
       const store = {
         state: {
+          statuses: {
             notifications: {
               data: [
                 {
@@ -70,8 +71,7 @@ describe('NotificationUtils', () => {
               ]
             }
           },
-        getters: {
+          config: {
-          mergedConfig: {
             notificationVisibility: {
               likes: true,
               repeats: true,

yarn.lock

@@ -2345,10 +2345,10 @@
   dependencies:
     js-beautify "1.14.6"
 
-"@vuelidate/core@2.0.3":
+"@vuelidate/core@2.0.2":
-  version "2.0.3"
+  version "2.0.2"
-  resolved "https://registry.yarnpkg.com/@vuelidate/core/-/core-2.0.3.tgz#40468c5ed15b72bde880a026b0699c2f0f1ecede"
+  resolved "https://registry.yarnpkg.com/@vuelidate/core/-/core-2.0.2.tgz#e874afc830ccc5295e83a0c0a0f0621e084348c9"
-  integrity sha512-AN6l7KF7+mEfyWG0doT96z+47ljwPpZfi9/JrNMkOGLFv27XVZvKzRLXlmDPQjPl/wOB1GNnHuc54jlCLRNqGA==
+  integrity sha512-aG1OZWv6xVws3ljyKy/pyxq1rdZZ2ryj+FEREcC9d4GP4qOvNHHZUl/NQxa0Bck3Ooc0RfXU8vwCA9piRoWy6w==
   dependencies:
     vue-demi "^0.13.11"